Skip to content

CI/TST: Skip another s3 test that can crash GHA worker #45651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 27, 2022
Merged

CI/TST: Skip another s3 test that can crash GHA worker #45651

merged 6 commits into from
Jan 27, 2022

Conversation

mroeschke
Copy link
Member

Example from https://github.com/pandas-dev/pandas/runs/4957463823?check_suite_focus=true

.....ss...s...s.........sss..........ss..........ss..................ssssss...s...s...x.............................XXXXXXXXX.XxXX2022-01-26 21:25:12,489 - s3fs - DEBUG - Setting up s3fs instance
2022-01-26T21:25:12.5442600Z 2022-01-26 21:25:12,543 - s3fs - DEBUG - Get directory listing page for pandas-test
2022-01-26T21:25:12.5650735Z 2022-01-26 21:25:12,564 - s3fs - DEBUG - Fetch: pandas-test/large-file.csv, 0-5505024
2022-01-26T22:08:22.5747205Z ##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
2022-01-26T22:08:23.3842467Z

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite CI Continuous Integration IO Network Local or Cloud (AWS, GCS, etc.) IO Issues labels Jan 26, 2022
jbrockmendel
jbrockmendel approved these changes Jan 27, 2022
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroeschke mroeschke added this to the 1.4.1 milestone Jan 27, 2022
@mroeschke
Copy link
Member Author

Appears to also happen for test_user_agent.py so skipping as well

2022-01-27T01:05:08.3878329Z ...................................127.0.0.1 - - [27/Jan/2022 01:05:07] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:08.5454000Z ......................................127.0.0.1 - - [27/Jan/2022 01:05:08] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:09.2164525Z .................................127.0.0.1 - - [27/Jan/2022 01:05:09] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:09.9411631Z ..................................127.0.0.1 - - [27/Jan/2022 01:05:09] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:10.4353956Z .................127.0.0.1 - - [27/Jan/2022 01:05:10] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:11.0281578Z .........................127.0.0.1 - - [27/Jan/2022 01:05:11] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:11.7202508Z .................................127.0.0.1 - - [27/Jan/2022 01:05:11] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:12.2688780Z ...............127.0.0.1 - - [27/Jan/2022 01:05:12] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:12.7840837Z .............127.0.0.1 - - [27/Jan/2022 01:05:12] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:13.5826589Z ............................127.0.0.1 - - [27/Jan/2022 01:05:13] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:14.1037063Z .......127.0.0.1 - - [27/Jan/2022 01:05:14] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:14.6141578Z 127.0.0.1 - - [27/Jan/2022 01:05:14] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:15.1163350Z 127.0.0.1 - - [27/Jan/2022 01:05:15] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:15.6335235Z .127.0.0.1 - - [27/Jan/2022 01:05:15] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:16.3507605Z ...........................127.0.0.1 - - [27/Jan/2022 01:05:16] "GET / HTTP/1.1" 200 -
2022-01-27T01:05:16.8827726Z .x....127.0.0.1 - - [27/Jan/2022 01:05:16] "GET / HTTP/1.1" 200 -
2022-01-27T01:54:41.2645176Z ##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
2022-01-27T01:54:43.1456377Z

@mroeschke mroeschke mentioned this pull request Jan 27, 2022
Closed
@mroeschke
Copy link
Member Author

Fastparquet was fixed on 310 so adding that here too: dask/fastparquet#739

@mroeschke
Copy link
Member Author

Greenish-er.

@mroeschke mroeschke merged commit 20d0964 into pandas-dev:main Jan 27, 2022
@mroeschke mroeschke deleted the ci/skip_flakey_test branch January 27, 2022 07:12
@mroeschke
Copy link
Member Author

@meeseeksdev backport 1.4.x

@lumberbot-app

This comment has been minimized.

Sign in to view
@lumberbot-app

This comment has been minimized.

Sign in to view
jbrockmendel
jbrockmendel reviewed Jan 27, 2022
View reviewed changes
pandas/tests/io/test_user_agent.py
import pandas.util._test_decorators as td

import pandas as pd
import pandas._testing as tm

pytestmark = pytest.mark.skipif(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is gonna make life better!

@mroeschke mroeschke modified the milestones: 1.4.1, 1.5 Jan 28, 2022
@mroeschke
Copy link
Member Author

Actually I think this is okay not to backport

@simonjayhawkins simonjayhawkins mentioned this pull request Feb 1, 2022
Merged
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Feb 1, 2022
@mroeschke @simonjayhawkins
Backport PR pandas-dev#45651: CI/TST: Skip another s3 test that can c…
95cb899 
…rash GHA worker
@simonjayhawkins simonjayhawkins mentioned this pull request Feb 1, 2022
Merged
@simonjayhawkins simonjayhawkins removed this from the 1.5 milestone Feb 1, 2022
@simonjayhawkins simonjayhawkins added this to the 1.4.1 milestone Feb 1, 2022
simonjayhawkins added a commit that referenced this pull request Feb 1, 2022
@simonjayhawkins @mroeschke
Backport PR #45651: CI/TST: Skip another s3 test that can crash GHA w…
f338819 
…orker (#45761)

Co-authored-by: Matthew Roeschke <[email protected]>
@Daquisu Daquisu mentioned this pull request Mar 21, 2022
Merged
4 tasks
@LucasG0 LucasG0 mentioned this pull request Jun 6, 2022
Merged
4 tasks
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@mroeschke @yehoshuadimarsky
CI/TST: Skip another s3 test that can crash GHA worker (pandas-dev#45651
1fc3b8a 
)

* CI/TST: Skip another s3 test that can crash GHA worker

* skip test_user_agent

* xfail strict=False another flakey test

* Fix xfail condition

* Fastparquet was fixed too

* Accidentally removed too much
@fangchenli fangchenli mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration IO Network Local or Cloud (AWS, GCS, etc.) IO Issues Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @jbrockmendel @simonjayhawkins