BUG: Fix joining overlapping IntervalIndex objects (GH-45661) #45662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Jan 27, 2022
johannes-mueller
force-pushed
the
bugfix/join-overlapping-itervalindex
branch
2 times, most recently
from
80a2647 to
6c1c732
Compare
phofl
reviewed
Jan 28, 2022
Replacing calls to `get_indexer()` with `get_indexer_for()` as `IntervalIndex`es can be unique and overlapping. Similar to pandas-dev#44588
johannes-mueller
force-pushed
the
bugfix/join-overlapping-itervalindex
branch
from
6c1c732 to
8bedde5
Compare
phofl
approved these changes
Jan 28, 2022
jreback
added
Index
|
thanks @johannes-mueller very nice |
|
@meeseeksdev backport 1.4.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 28, 2022
|
Something went wrong ... Please have a look at my logs. |
phofl
pushed a commit
that referenced
this pull request
Jan 28, 2022
GH-45661) (#45682) Co-authored-by: Johannes Mueller <[email protected]>
|
@jbrockmendel this has been backported. The PR that is the cause of the regression was #43692 which was some changes specifically targeted at IntervalIndex handling. The changes in this PR affect all Index types? (and the function changed is no longer appropriately named?) Can you give this a quick look and thumbs up before we release 1.4.1 (end of this week) |
|
This looks fine to me. |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing calls to
get_indexer()withget_indexer_for()asIntervalIndexes can be unique and overlapping.Similar to #44588