Skip to content

BUG: Fix joining overlapping IntervalIndex objects (GH-45661) #45662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v1.4.1.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Fixed regressions
~~~~~~~~~~~~~~~~~
- Regression in :meth:`Series.mask` with ``inplace=True`` and ``PeriodDtype`` and an incompatible ``other`` coercing to a common dtype instead of raising (:issue:`45546`)
- Regression in :meth:`DataFrame.loc.__setitem__` losing :class:`Index` name if :class:`DataFrame` was empty before (:issue:`45621`)
- Regression in :func:`join` with overlapping :class:`IntervalIndex` raising an ``InvalidIndexError`` (:issue:`45661`)
-

.. ---------------------------------------------------------------------------
Expand Down
4 changes: 2 additions & 2 deletions pandas/core/indexes/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -4580,11 +4580,11 @@ def _join_via_get_indexer(
if join_index is self:
lindexer = None
else:
lindexer = self.get_indexer(join_index)
lindexer = self.get_indexer_for(join_index)
if join_index is other:
rindexer = None
else:
rindexer = other.get_indexer(join_index)
rindexer = other.get_indexer_for(join_index)
return join_index, lindexer, rindexer

@final
Expand Down
44 changes: 44 additions & 0 deletions pandas/tests/indexes/interval/test_join.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import pytest

from pandas import (
IntervalIndex,
MultiIndex,
RangeIndex,
)
import pandas._testing as tm


@pytest.fixture
def range_index():
return RangeIndex(3, name="range_index")


@pytest.fixture
def interval_index():
return IntervalIndex.from_tuples(
[(0.0, 1.0), (1.0, 2.0), (1.5, 2.5)], name="interval_index"
)


def test_join_overlapping_in_mi_to_same_intervalindex(range_index, interval_index):
# GH-45661
multi_index = MultiIndex.from_product([interval_index, range_index])
result = multi_index.join(interval_index)

tm.assert_index_equal(result, multi_index)


def test_join_overlapping_to_multiindex_with_same_interval(range_index, interval_index):
# GH-45661
multi_index = MultiIndex.from_product([interval_index, range_index])
result = interval_index.join(multi_index)

tm.assert_index_equal(result, multi_index)


def test_join_overlapping_interval_to_another_intervalindex(interval_index):
# GH-45661
flipped_interval_index = interval_index[::-1]
result = interval_index.join(flipped_interval_index)

tm.assert_index_equal(result, interval_index)