Skip to content

Commit 24d18ea

Browse files
johannes-muelleryehoshuadimarsky
authored andcommitted
BUG: Fix joining overlapping IntervalIndex objects (pandas-devGH-45661) (pandas-dev#45662)
1 parent 827591f commit 24d18ea

File tree

3 files changed

+47
-2
lines changed

3 files changed

+47
-2
lines changed

doc/source/whatsnew/v1.4.1.rst

+1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ Fixed regressions
1818
- Regression in :func:`.assert_frame_equal` not respecting ``check_flags=False`` (:issue:`45554`)
1919
- Regression in :meth:`Series.fillna` with ``downcast=False`` incorrectly downcasting ``object`` dtype (:issue:`45603`)
2020
- Regression in :meth:`DataFrame.loc.__setitem__` losing :class:`Index` name if :class:`DataFrame` was empty before (:issue:`45621`)
21+
- Regression in :func:`join` with overlapping :class:`IntervalIndex` raising an ``InvalidIndexError`` (:issue:`45661`)
2122
-
2223

2324
.. ---------------------------------------------------------------------------

pandas/core/indexes/base.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -4587,11 +4587,11 @@ def _join_via_get_indexer(
45874587
if join_index is self:
45884588
lindexer = None
45894589
else:
4590-
lindexer = self.get_indexer(join_index)
4590+
lindexer = self.get_indexer_for(join_index)
45914591
if join_index is other:
45924592
rindexer = None
45934593
else:
4594-
rindexer = other.get_indexer(join_index)
4594+
rindexer = other.get_indexer_for(join_index)
45954595
return join_index, lindexer, rindexer
45964596

45974597
@final
+44
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
import pytest
2+
3+
from pandas import (
4+
IntervalIndex,
5+
MultiIndex,
6+
RangeIndex,
7+
)
8+
import pandas._testing as tm
9+
10+
11+
@pytest.fixture
12+
def range_index():
13+
return RangeIndex(3, name="range_index")
14+
15+
16+
@pytest.fixture
17+
def interval_index():
18+
return IntervalIndex.from_tuples(
19+
[(0.0, 1.0), (1.0, 2.0), (1.5, 2.5)], name="interval_index"
20+
)
21+
22+
23+
def test_join_overlapping_in_mi_to_same_intervalindex(range_index, interval_index):
24+
# GH-45661
25+
multi_index = MultiIndex.from_product([interval_index, range_index])
26+
result = multi_index.join(interval_index)
27+
28+
tm.assert_index_equal(result, multi_index)
29+
30+
31+
def test_join_overlapping_to_multiindex_with_same_interval(range_index, interval_index):
32+
# GH-45661
33+
multi_index = MultiIndex.from_product([interval_index, range_index])
34+
result = interval_index.join(multi_index)
35+
36+
tm.assert_index_equal(result, multi_index)
37+
38+
39+
def test_join_overlapping_interval_to_another_intervalindex(interval_index):
40+
# GH-45661
41+
flipped_interval_index = interval_index[::-1]
42+
result = interval_index.join(flipped_interval_index)
43+
44+
tm.assert_index_equal(result, interval_index)

0 commit comments

Comments
 (0)