Skip to content

TYP: Fix mypy error in core.py #45098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

kashifkhan
Copy link
Contributor

xref #37715

Assign the values to handles and labels itself versus changing the types of the self.legend_handles and self.legend_labels

@jreback jreback added the Typing type annotations, mypy/pyright type checking label Dec 28, 2021
@jreback jreback added this to the 1.4 milestone Dec 28, 2021
@jreback jreback merged commit 384f627 into pandas-dev:master Dec 28, 2021
@jreback
Copy link
Contributor

jreback commented Dec 28, 2021

thanks @kashifkhan

@kashifkhan kashifkhan deleted the fix_mypy_err_core.py branch December 28, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants