Skip to content

TYP: Fix mypy error in core.py #45098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2021
Merged

TYP: Fix mypy error in core.py #45098

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 6 additions & 15 deletions pandas/plotting/_matplotlib/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ def _append_legend_handles_labels(self, handle: Artist, label: str) -> None:
self.legend_handles.append(handle)
self.legend_labels.append(label)

def _make_legend(self):
def _make_legend(self) -> None:
ax, leg = self._get_ax_legend(self.axes[0])

handles = []
Expand All @@ -664,20 +664,11 @@ def _make_legend(self):

if self.legend:
if self.legend == "reverse":
# error: Incompatible types in assignment (expression has type
# "Iterator[Any]", variable has type "List[Any]")
self.legend_handles = reversed( # type: ignore[assignment]
self.legend_handles
)
# error: Incompatible types in assignment (expression has type
# "Iterator[Hashable]", variable has type
# "List[Hashable]")
self.legend_labels = reversed( # type: ignore[assignment]
self.legend_labels
)

handles += self.legend_handles
labels += self.legend_labels
handles += reversed(self.legend_handles)
labels += reversed(self.legend_labels)
else:
handles += self.legend_handles
labels += self.legend_labels

if self.legend_title is not None:
title = self.legend_title
Expand Down