Skip to content

Commit 384f627

Browse files
kashifkhanKashif Khan
and
Kashif Khan
authored
TYP: fix mypy error in core.py (#45098)
Co-authored-by: Kashif Khan <[email protected]>
1 parent ddd77dc commit 384f627

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

pandas/plotting/_matplotlib/core.py

+6-15
Original file line numberDiff line numberDiff line change
@@ -648,7 +648,7 @@ def _append_legend_handles_labels(self, handle: Artist, label: str) -> None:
648648
self.legend_handles.append(handle)
649649
self.legend_labels.append(label)
650650

651-
def _make_legend(self):
651+
def _make_legend(self) -> None:
652652
ax, leg = self._get_ax_legend(self.axes[0])
653653

654654
handles = []
@@ -664,20 +664,11 @@ def _make_legend(self):
664664

665665
if self.legend:
666666
if self.legend == "reverse":
667-
# error: Incompatible types in assignment (expression has type
668-
# "Iterator[Any]", variable has type "List[Any]")
669-
self.legend_handles = reversed( # type: ignore[assignment]
670-
self.legend_handles
671-
)
672-
# error: Incompatible types in assignment (expression has type
673-
# "Iterator[Hashable]", variable has type
674-
# "List[Hashable]")
675-
self.legend_labels = reversed( # type: ignore[assignment]
676-
self.legend_labels
677-
)
678-
679-
handles += self.legend_handles
680-
labels += self.legend_labels
667+
handles += reversed(self.legend_handles)
668+
labels += reversed(self.legend_labels)
669+
else:
670+
handles += self.legend_handles
671+
labels += self.legend_labels
681672

682673
if self.legend_title is not None:
683674
title = self.legend_title

0 commit comments

Comments
 (0)