STYLE: upgrade flake8 to version 4+ #45053
Conversation
MiTo0o
commented
Dec 24, 2021
MiTo0o
commented
- closes STYLE upgrade flake8 to version 4+ #45051
- tests passed
- Ensure all linting tests pass, see here for how to run them
- bumping version of flake8 and update repo url
|
Sorry I'm unfamiliar with the |
.pre-commit-config.yaml
Outdated
| - flake8==3.9.2 | ||
| - flake8-comprehensions==3.1.0 | ||
| - flake8==4.0.1 | ||
| - flake8-comprehensions==3.7.0 | ||
| - flake8-bugbear==21.3.2 | ||
| - pandas-dev-flaker==0.2.0 | ||
| - id: flake8 |
There was a problem hiding this comment.
looks like flake8 v4 no longer works on Cython files (and that if it did before, it was purely by accident) PyCQA/flake8#1482
@jbrockmendel how important is flake8 linting of cython files? Is it OK to remove it, or would you rather have a separate hook for cython linting which pins flake8 at 3.9.2?
There was a problem hiding this comment.
id be OK with not having it; i get false-positives about "cimport" all the time
There was a problem hiding this comment.
sure, it's a hack anyway - @MiTo0o can you remove these cython flake8 checks too please, as well as their config files?
There was a problem hiding this comment.
Sounds good, I just pushed some changes, lets see if I pass everything and if it meets your expectations.
