Skip to content

STYLE upgrade flake8 to version 4+ #45051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcoGorelli opened this issue Dec 24, 2021 · 2 comments · Fixed by #45053
Closed

STYLE upgrade flake8 to version 4+ #45051

MarcoGorelli opened this issue Dec 24, 2021 · 2 comments · Fixed by #45053
Labels
Code Style Code style, linting, code_checks good first issue
Milestone
1.4

Comments

@MarcoGorelli
Copy link
Member

flake8 isn't getting updated by the auto-update job because the url

pandas/.pre-commit-config.yaml

Lines 38 to 39 in 7131268

- repo: https://gitlab.com/pycqa/flake8
rev: 3.9.2

has changed. flake8 is now hosted at https://github.com/PyCQA/flake8 .

Task here is to change the repo url, set the latest flake8 version, and fixup any errors which result from

pre-commit run flake8 --all-files
@MarcoGorelli MarcoGorelli added Code Style Code style, linting, code_checks good first issue labels Dec 24, 2021
@MiTo0o MiTo0o mentioned this issue Dec 24, 2021
Merged
4 tasks
@pranay101
Copy link

I would like to work on this.

@MarcoGorelli
Copy link
Member Author

there's already #45053

@jreback jreback added this to the 1.4 milestone Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks good first issue
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

STYLE: upgrade flake8 to version 4+
3 participants
@jreback @MarcoGorelli @pranay101