Skip to content

Commit 5606684

Browse files
authored
STYLE: upgrade flake8 to version 4+ (#45053)
* update flake repo url and flake version * bump flake8 and flake8 related dependencies * revert one of the dependency dumps * remove cython from flake8 lint
1 parent 6de11bb commit 5606684

File tree

5 files changed

+8
-34
lines changed

5 files changed

+8
-34
lines changed

.pre-commit-config.yaml

+4-14
Original file line numberDiff line numberDiff line change
@@ -35,25 +35,15 @@ repos:
3535
# we can lint all header files since they aren't "generated" like C files are.
3636
exclude: ^pandas/_libs/src/(klib|headers)/
3737
args: [--quiet, '--extensions=c,h', '--headers=h', --recursive, '--filter=-readability/casting,-runtime/int,-build/include_subdir']
38-
- repo: https://gitlab.com/pycqa/flake8
39-
rev: 3.9.2
38+
- repo: https://github.com/PyCQA/flake8
39+
rev: 4.0.1
4040
hooks:
4141
- id: flake8
4242
additional_dependencies: &flake8_dependencies
43-
- flake8==3.9.2
44-
- flake8-comprehensions==3.1.0
43+
- flake8==4.0.1
44+
- flake8-comprehensions==3.7.0
4545
- flake8-bugbear==21.3.2
4646
- pandas-dev-flaker==0.2.0
47-
- id: flake8
48-
alias: flake8-cython
49-
name: flake8 (cython)
50-
types: [cython]
51-
args: [--append-config=flake8/cython.cfg]
52-
- id: flake8
53-
name: flake8 (cython template)
54-
files: \.pxi\.in$
55-
types: [text]
56-
args: [--append-config=flake8/cython-template.cfg]
5747
- repo: https://github.com/PyCQA/isort
5848
rev: 5.10.1
5949
hooks:

environment.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ dependencies:
2020
# code checks
2121
- black=21.5b2
2222
- cpplint
23-
- flake8=3.9.2
23+
- flake8=4.0.1
2424
- flake8-bugbear=21.3.2 # used by flake8, find likely bugs
25-
- flake8-comprehensions=3.1.0 # used by flake8, linting of unnecessary comprehensions
25+
- flake8-comprehensions=3.7.0 # used by flake8, linting of unnecessary comprehensions
2626
- isort>=5.2.1 # check that imports are in the right order
2727
- mypy=0.920
2828
- pre-commit>=2.9.2

flake8/cython-template.cfg

-3
This file was deleted.

flake8/cython.cfg

-13
This file was deleted.

requirements-dev.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ asv
88
cython>=0.29.24
99
black==21.5b2
1010
cpplint
11-
flake8==3.9.2
11+
flake8==4.0.1
1212
flake8-bugbear==21.3.2
13-
flake8-comprehensions==3.1.0
13+
flake8-comprehensions==3.7.0
1414
isort>=5.2.1
1515
mypy==0.920
1616
pre-commit>=2.9.2

0 commit comments

Comments
 (0)