CI: adding cython coverage #43660
CI: adding cython coverage #43660
Conversation
| @@ -0,0 +1,2 @@ | |||
| [run] | |||
There was a problem hiding this comment.
can this go in the coverage section of setup.cfg?
There was a problem hiding this comment.
tried that in another repo. it has it be in .coveragerc
There was a problem hiding this comment.
OK, if this file is re-introduced, then probably should move the coverage stuff currently in setup.cfg (which currently includes this Cython.Coverage line)
There was a problem hiding this comment.
tried that in another repo. it has it be in .coveragerc
Are you sure? I just did a test run locally after building using --with-cython-coverage and it seemed to work fine.
There was a problem hiding this comment.
you're right. my bad!
There was a problem hiding this comment.
Great can you move to setup.cfg then?
ci/setup_env.sh
Outdated
| @@ -103,7 +103,7 @@ conda list pandas | |||
| # Make sure any error below is reported as such | |||
|
|
|||
| echo "[Build extensions]" | |||
| python setup.py build_ext -q -j2 | |||
| python setup.py build_ext -q -j2 --with-cython-coverage | |||
There was a problem hiding this comment.
im pretty sure we dont want this on every build, since it slows things down a lot.
There was a problem hiding this comment.
makes sense.. would you know why the build is failing though?
There was a problem hiding this comment.
pandas/_libs/algos.c: In function ‘__pyx_fuse_0__pyx_f_6pandas_5_libs_5algos_rank_sorted_1d.isra.0.constprop’:
pandas/_libs/algos.c:1023:34: error: ‘__pyx_gilstate_save’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
1023 | #define __Pyx_PyGILState_Release PyGILState_Release
| ^~~~~~~~~~~~~~~~~~
pandas/_libs/algos.c:73649:20: note: ‘__pyx_gilstate_save’ was declared here
73649 | PyGILState_STATE __pyx_gilstate_save;
| @@ -0,0 +1,84 @@ | |||
| name: Python build with Cython | |||
There was a problem hiding this comment.
umm we need another build? can you do it in an existing one
|
@debnathshoham - do you still want to work on this? See comments above - H2H if needed |
|
This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this. |
|
closing as stale |
Trying to include cython codes in codecov reports.
Working with the CI for the first time.