-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CI: adding cython coverage #43660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
CI: adding cython coverage #43660
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
09e0165
add cython coverage
debnathshoham e55bdbf
--define CYTHON_TRACE
debnathshoham c5abdb0
updated setup_env.sh
debnathshoham 861028c
annotate coverage
debnathshoham be04471
using --with-cython-coverage
debnathshoham dab931c
removed with-cython-coverage from setup_env.sh
debnathshoham 80ee5f8
build inplace pandas-dev
debnathshoham 0ae6715
Merge branch 'master' into gh43652
debnathshoham 5839e24
-Wno-error=maybe-uninitialized
debnathshoham 14f1ceb
test a-z
debnathshoham c502b73
add pandas-dev-cython
debnathshoham 5cc3ea8
renamed test split
debnathshoham 0251f15
changed concurrency
debnathshoham 5dfe3dd
cython on non-python-dev version
debnathshoham ae9bd98
cython on non-python-dev version
debnathshoham 02d927c
Update python-cython.yml
debnathshoham 9ef035d
removed env to strategy
debnathshoham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
[run] | ||
plugins = Cython.Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
name: Python build with Cython | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. umm we need another build? can you do it in an existing one |
||
|
||
on: | ||
push: | ||
branches: | ||
- master | ||
- 1.3.x | ||
pull_request: | ||
branches: | ||
- master | ||
- 1.3.x | ||
paths-ignore: | ||
- "doc/**" | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
name: python_cython_build | ||
timeout-minutes: 60 | ||
|
||
strategy: | ||
matrix: | ||
PYTEST_WORKERS: "auto" | ||
PATTERN: "not slow and not network and not clipboard" | ||
COVERAGE: true | ||
PYTEST_TARGET: ["pandas/tests/[a-h]*", "pandas/tests/[i-z]*"] | ||
|
||
concurrency: | ||
group: ${{ github.ref }}-${{ matrix.PYTEST_TARGET }} | ||
cancel-in-progress: ${{github.event_name == 'pull_request'}} | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
|
||
- name: Install dependencies | ||
run: | | ||
python -m pip install --upgrade pip setuptools wheel | ||
pip install -i https://pypi.anaconda.org/scipy-wheels-nightly/simple numpy | ||
pip install git+https://github.com/pytest-dev/pytest.git | ||
pip install git+https://github.com/nedbat/coveragepy.git | ||
pip install cython python-dateutil pytz hypothesis pytest-xdist pytest-cov | ||
pip list | ||
|
||
- name: Build Pandas | ||
run: | | ||
python setup.py build_ext -q -j2 --with-cython-coverage | ||
python -m pip install -e . --no-build-isolation --no-use-pep517 | ||
|
||
- name: Build Version | ||
run: | | ||
python -c "import pandas; pandas.show_versions();" | ||
|
||
- name: Test with pytest | ||
run: | | ||
ci/run_tests.sh | ||
# GH 41935 | ||
continue-on-error: true | ||
|
||
- name: Publish test results | ||
uses: actions/upload-artifact@master | ||
with: | ||
name: Test results | ||
path: test-data.xml | ||
if: failure() | ||
|
||
- name: Print skipped tests | ||
run: | | ||
python ci/print_skipped.py | ||
|
||
- name: Report Coverage | ||
run: | | ||
coverage report -m | ||
|
||
- name: Upload coverage to Codecov | ||
uses: codecov/codecov-action@v2 | ||
with: | ||
flags: unittests | ||
name: codecov-pandas | ||
fail_ci_if_error: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this go in the coverage section of setup.cfg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tried that in another repo. it has it be in
.coveragerc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, if this file is re-introduced, then probably should move the coverage stuff currently in setup.cfg (which currently includes this Cython.Coverage line)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure? I just did a test run locally after building using
--with-cython-coverage
and it seemed to work fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right. my bad!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great can you move to setup.cfg then?