Skip to content

CI: codecov for pyx files #43652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
twoertwein opened this issue Sep 18, 2021 · 4 comments
Closed

CI: codecov for pyx files #43652

twoertwein opened this issue Sep 18, 2021 · 4 comments
Labels
CI Continuous Integration Enhancement

Comments

@twoertwein
Copy link
Member

Is your feature request related to a problem?

cython supports line coverage but pyx files are currently not included in the codecov reports. Having code coverage for cython code might help to remove unused cython code.

Describe the solution you'd like

pyx files are included in the codecov report.
@twoertwein twoertwein added Enhancement Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 18, 2021
@lithomas1 lithomas1 added CI Continuous Integration and removed Needs Triage Issue that has not been reviewed by a pandas team member labels Sep 18, 2021
@lithomas1 lithomas1 added this to the Contributions Welcome milestone Sep 18, 2021
@debnathshoham debnathshoham mentioned this issue Sep 19, 2021
Closed
1 task
@jbrockmendel
Copy link
Member

xref #25600

@twoertwein
Copy link
Member Author

xref #25600

If running cython with line coverage is much slower, having a nightly build as mentioned in the issue might be a better option. Happy to close this issue.

@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@jbrockmendel
Copy link
Member

are we even still using codecov?

@twoertwein
Copy link
Member Author

I don't see it run anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: adding cython coverage debnathshoham/pandas
4 participants
@twoertwein @jbrockmendel @mroeschke @lithomas1