CI: troubleshoot py310 build #41990
CI: troubleshoot py310 build #41990
Conversation
jbrockmendel
commented
Jun 14, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
pandas/core/algorithms.py
Outdated
| @@ -1092,18 +1093,19 @@ def checked_add_with_arr( | |||
| # it is negative, we then check whether its sum with the element in | |||
| # 'arr' exceeds np.iinfo(np.int64).min. If so, we have an overflow | |||
| # error as well. | |||
| i8max = Timestamp.max.value # GH#? | |||
There was a problem hiding this comment.
can u make these consistent across all of the files
iow this is called different names but the same even in this change set
There was a problem hiding this comment.
will standardize in next commit. this kludge really shouldn't be necessary
There was a problem hiding this comment.
ping, will be nice to finally get back to green
There was a problem hiding this comment.
right what i mean was can you standardize these names (you mostly do, but some are CAPITAL and some not). prefer to do it in this PR as going to backport.
There was a problem hiding this comment.
the ones in .py files are all i8max, u8max, or iNaT
|
Hey @jbrockmendel Just giving the heads up that the Python 3.10 dev build was actually "fake" green and can be green even if failing. (was actually failing even when it was "green"). I'm trying to address that in #41595, so I guess you can ignore failures listed on the issue #41940 in this PR. Also, FYI the Python dev build on tests on a single core, so you might find it helpful to change add an |
|
Thanks @lithomas1. IIUC what we really want is allow-failure which GH actions doesn't support (actions/runner#2347). For now I'll be happy if non-breaking PRs get a little green checkmark. |
|
@jbrockmendel there's some mypy failures |
The last time I tried, only single core works. We probably should try pytest-xdist master now. |
|
Remaining failures look unrelated |
pandas/core/sorting.py
Outdated
| @@ -40,7 +40,7 @@ | |||
| from pandas import MultiIndex | |||
| from pandas.core.indexes.base import Index | |||
|
|
|||
| _INT64_MAX = np.iinfo(np.int64).max | |||
| _INT64_MAX = lib.i8max | |||
There was a problem hiding this comment.
can u fix these rather than just renaming
There was a problem hiding this comment.
alt change the ones in the .pyx to be uppercase
it's not at all clear that these are actually the same
| @@ -25,6 +25,9 @@ class NoDefault(Enum): ... | |||
|
|
|||
| no_default: NoDefault | |||
|
|
|||
| i8max: int | |||
There was a problem hiding this comment.
i still find this odd, pls do in a followup (e.g. change these to the same naming as in util e.t. INT64_MAX)
|
tell you what. i like green, so if you can do a followup for the name cleaning (which we can backport to 1.3) |
|
@meeseeksdev backport 1.3.x |
|
Something went wrong ... Please have a look at my logs. |
Co-authored-by: jbrockmendel <[email protected]>
