-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CI: troubleshoot py310 build #41990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: troubleshoot py310 build #41990
Changes from 8 commits
6acd43e
b8debba
03e549e
5a822b7
6e22d6b
0222c6a
d888836
0fadfdc
c543387
81da403
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,7 +40,7 @@ | |
from pandas import MultiIndex | ||
from pandas.core.indexes.base import Index | ||
|
||
_INT64_MAX = np.iinfo(np.int64).max | ||
_INT64_MAX = lib.i8max | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can u fix these rather than just renaming There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. alt change the ones in the .pyx to be uppercase it's not at all clear that these are actually the same There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated+green |
||
|
||
|
||
def get_indexer_indexer( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i still find this odd, pls do in a followup (e.g. change these to the same naming as in util e.t. INT64_MAX)