CI/TYP: Window typing followup #40392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Typing
|
Thanks for the follow-up! |
| @@ -589,7 +586,7 @@ def quantile( | |||
| ) | |||
| def cov( | |||
| self, | |||
| other: Optional[Union[np.ndarray, FrameOrSeriesUnion]] = None, | |||
| other: Optional[FrameOrSeriesUnion] = None, | |||
There was a problem hiding this comment.
How is this change correct? Or is the docstring not correct? (which says that other can also be an ndarray)
There was a problem hiding this comment.
At least on master, passing a numpy array raises
In [1]: pd.Series(range(10)).expanding().cov(np.arange(10))
Exception: Input arrays must be of the same type!
as well there's a test, test_different_input_array_raise_exception that checks that an Exception is raised with a numpy array.
So I can follow up fixing the documentation
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe #40293 may have caused the current typing failures in the CI