Skip to content

TYP: Window code #40293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2021
Merged

TYP: Window code #40293

merged 2 commits into from
Mar 12, 2021

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

@mroeschke mroeschke added this to the 1.3 milestone Mar 8, 2021
@mroeschke mroeschke added Typing type annotations, mypy/pyright type checking Window rolling, ewma, expanding labels Mar 8, 2021
@mroeschke mroeschke changed the title TYPE: Window code TYP: Window code Mar 8, 2021
jreback
jreback approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. cc @simonjayhawkins if comments

@mroeschke
Copy link
Member Author

Happy to have a subsequent PR will follow up comments.

@mroeschke mroeschke merged commit 63bfdf5 into pandas-dev:master Mar 12, 2021
@mroeschke mroeschke deleted the type/ewm branch March 12, 2021 00:25
@mroeschke mroeschke mentioned this pull request Mar 12, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking Window rolling, ewma, expanding
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jreback