Skip to content

Commit bed5ae2

Browse files
authored
CI/TYP: Window typing followup (#40392)
1 parent d008640 commit bed5ae2

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

pandas/core/generic.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -11014,7 +11014,9 @@ def ewm(
1101411014
times: Optional[Union[str, np.ndarray, FrameOrSeries]] = None,
1101511015
) -> ExponentialMovingWindow:
1101611016
axis = self._get_axis_number(axis)
11017-
return ExponentialMovingWindow(
11017+
# error: Value of type variable "FrameOrSeries" of "ExponentialMovingWindow"
11018+
# cannot be "object"
11019+
return ExponentialMovingWindow( # type: ignore[type-var]
1101811020
self,
1101911021
com=com,
1102011022
span=span,

pandas/core/window/expanding.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,8 @@
55
Dict,
66
Optional,
77
Tuple,
8-
Union,
98
)
109

11-
import numpy as np
12-
1310
from pandas._typing import (
1411
Axis,
1512
FrameOrSeries,
@@ -589,7 +586,7 @@ def quantile(
589586
)
590587
def cov(
591588
self,
592-
other: Optional[Union[np.ndarray, FrameOrSeriesUnion]] = None,
589+
other: Optional[FrameOrSeriesUnion] = None,
593590
pairwise: Optional[bool] = None,
594591
ddof: int = 1,
595592
**kwargs,
@@ -654,7 +651,7 @@ def cov(
654651
)
655652
def corr(
656653
self,
657-
other: Optional[Union[np.ndarray, FrameOrSeriesUnion]] = None,
654+
other: Optional[FrameOrSeriesUnion] = None,
658655
pairwise: Optional[bool] = None,
659656
ddof: int = 1,
660657
**kwargs,

pandas/core/window/rolling.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -1354,7 +1354,7 @@ def quantile(self, quantile: float, interpolation: str = "linear", **kwargs):
13541354

13551355
def cov(
13561356
self,
1357-
other: Optional[Union[np.ndarray, FrameOrSeriesUnion]] = None,
1357+
other: Optional[FrameOrSeriesUnion] = None,
13581358
pairwise: Optional[bool] = None,
13591359
ddof: int = 1,
13601360
**kwargs,
@@ -1392,7 +1392,7 @@ def cov_func(x, y):
13921392

13931393
def corr(
13941394
self,
1395-
other: Optional[Union[np.ndarray, FrameOrSeriesUnion]] = None,
1395+
other: Optional[FrameOrSeriesUnion] = None,
13961396
pairwise: Optional[bool] = None,
13971397
ddof: int = 1,
13981398
**kwargs,
@@ -2137,7 +2137,7 @@ def quantile(self, quantile: float, interpolation: str = "linear", **kwargs):
21372137
)
21382138
def cov(
21392139
self,
2140-
other: Optional[Union[np.ndarray, FrameOrSeriesUnion]] = None,
2140+
other: Optional[FrameOrSeriesUnion] = None,
21412141
pairwise: Optional[bool] = None,
21422142
ddof: int = 1,
21432143
**kwargs,
@@ -2262,7 +2262,7 @@ def cov(
22622262
)
22632263
def corr(
22642264
self,
2265-
other: Optional[Union[np.ndarray, FrameOrSeriesUnion]] = None,
2265+
other: Optional[FrameOrSeriesUnion] = None,
22662266
pairwise: Optional[bool] = None,
22672267
ddof: int = 1,
22682268
**kwargs,

0 commit comments

Comments
 (0)