DOC: fixes for assert_frame_equal check_freq argument #38471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylekeppler
changed the title
|
CI failures look unrelated? |
rhshadrach
reviewed
Dec 28, 2020
There was a problem hiding this comment.
Thanks for the PR - looks good. The only thing I'm wondering is if we want to create a new "API Breaking" section here or just move this to the top list of enhancements; any thoughts @TomAugspurger @jorisvandenbossche
jreback
requested changes
Dec 29, 2020
jreback
requested changes
Jan 1, 2021
jreback
approved these changes
Jan 1, 2021
|
thanks @kylekeppler |
This comment has been minimized.
This comment has been minimized.
kylekeppler
added a commit
to kylekeppler/pandas
that referenced
this pull request
Jan 1, 2021
5 tasks
simonjayhawkins
pushed a commit
that referenced
this pull request
Jan 2, 2021
4 tasks
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
* add versionadded to asset_frame_equals check_freq * Add whats new for assert_frame_equal check_freq arg. * fix backticks * move whatnew to 1.2.1 * whitespace * rename to API breaking section Co-authored-by: Keppler, Kyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffThis is just a minor documentation change to fix the
versionaddedtag on thecheck_freqargument toassert_frame_equaland also to add a description of this backwards incompatible chage to the 1.1.0 Whats New (as recommended in #35570 (comment)).