Skip to content

DOC: move API breaking "check_freq" section from v1.2.1rst to v1.1.0.rst #38957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

kylekeppler
Copy link
Contributor

and add reference to 1.1.0 whats new update in v1.2.1.rst

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

This moves the doc notes for assert_series_equal and assert_frame_equal from the 1.2.1 whats new to the 1.1.0 whats new and adds a small reference to the section in the 1.1.0 page in the 1.2.1 page. This came up in #38471 and makes more sense to me than the current approach, but happy to close if current state is preferred.

add reference to 1.1.0 whats new update in v1.2.1.rst
@jreback jreback added the Docs label Jan 4, 2021
@jreback jreback added this to the 1.2.1 milestone Jan 4, 2021
@jreback
Copy link
Contributor

jreback commented Jan 4, 2021

yeah this is better. of course there is no visibility of this 'change' as it happened in the past, but now documented.

thanks @kylekeppler

@jreback jreback merged commit 6033a89 into pandas-dev:master Jan 4, 2021
@jreback
Copy link
Contributor

jreback commented Jan 4, 2021

@meeseeksdev backport 1.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 4, 2021

Something went wrong ... Please have a look at my logs.

jreback pushed a commit that referenced this pull request Jan 5, 2021
@kylekeppler kylekeppler deleted the move_check_freq_whatsnew branch January 5, 2021 15:37
luckyvs1 pushed a commit to luckyvs1/pandas that referenced this pull request Jan 20, 2021
…ev#38957)

add reference to 1.1.0 whats new update in v1.2.1.rst

Co-authored-by: Keppler, Kyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants