Skip to content

Change the default of check_freq to False as it breaks existing code #35570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MaxWinterstein opened this issue Aug 5, 2020 · 2 comments
Closed

Change the default of check_freq to False as it breaks existing code #35570

MaxWinterstein opened this issue Aug 5, 2020 · 2 comments
Labels
Regression Functionality that used to work in a prior pandas version Testing pandas testing functions or related to the test suite

Comments

@MaxWinterstein
Copy link

MaxWinterstein commented Aug 5, 2020 •
edited
Loading

As already mentioned in #34050 the default of check_freq was set to True, which leads to broken code / tests.

I suggest to change it to False as it ensures existing code won't break.

k thanks. pls open an issue to change this to check_freq=False; I think this might break downstream, IIRC a comment by @jorisvandenbossche

Originally posted by @jreback in #34050 (comment)
@MaxWinterstein MaxWinterstein mentioned this issue Aug 5, 2020
Closed
5 tasks
@simonjayhawkins simonjayhawkins added this to the 1.1.1 milestone Aug 5, 2020
@simonjayhawkins simonjayhawkins added Testing pandas testing functions or related to the test suite Regression Functionality that used to work in a prior pandas version labels Aug 5, 2020
@jreback
Copy link
Contributor

jreback commented Aug 14, 2020

-1 on changing this.

@TomAugspurger
Copy link
Contributor

TomAugspurger commented Aug 14, 2020 •
edited
Loading

See #35571 (comment).

We would be happy to have an update to whatsnew/1.1.0.rst to reflect the (accidental) API change.

@TomAugspurger TomAugspurger modified the milestones: 1.1.1, No action Aug 14, 2020
@kylekeppler kylekeppler mentioned this issue Dec 14, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Regression Functionality that used to work in a prior pandas version Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change check_freq default to False
4 participants
@jreback @TomAugspurger @MaxWinterstein @simonjayhawkins