CI: check_freq=False #34050
Merged
CI: check_freq=False #34050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| @@ -1140,6 +1141,8 @@ def assert_series_equal( | |||
| Whether to compare internal Categorical exactly. | |||
| check_category_order : bool, default True | |||
| Whether to compare category order of internal Categoricals. | |||
| check_freq : bool, default True | |||
There was a problem hiding this comment.
move to below versionadded:: 1.0.2 for check_category_order and add versionadded:: 1.1.0
Comment on lines
+1334
to
+1335
| check_freq : bool, default True | ||
| Whether to check the `freq` attribute on a DatetimeIndex or TimedeltaIndex. |
There was a problem hiding this comment.
add versionadded:: 1.1.0
jreback
added
Testing
|
looks ok, comments by @simonjayhawkins |
|
comments addressed |
jreback
approved these changes
May 9, 2020
|
green |
|
k thanks. pls open an issue to change this to |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
May 10, 2020
Jepp, this broke some code for me. Will open the mentioned issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aimed at a test that has been periodically failing in the CI for a week or so.