-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Implement FloatingArray reductions #36778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @jorisvandenbossche
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
At some point, we should move the implementation (and tests) to a common "NumericArray", I suppose
actually if you rebase I think you can push these down to BaseMaskedArray entirely (or factor out to NumericMaskedArray if need to avoid the bool collision issues) |
great ping on green. |
thanks |
Mostly copy / paste from #36761
@jorisvandenbossche Would this require a whatsnew note? Seems the current v1.2.0 note is fairly high level and doesn't talk about specific methods that are supported. Should we talk about this or leave as-is?