Skip to content

ENH: Implement FloatingArray reductions #36778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 3, 2020
Merged

ENH: Implement FloatingArray reductions #36778

merged 7 commits into from
Oct 3, 2020

Conversation

dsaxton
Copy link
Member

@dsaxton dsaxton commented Oct 1, 2020

Mostly copy / paste from #36761

@jorisvandenbossche Would this require a whatsnew note? Seems the current v1.2.0 note is fairly high level and doesn't talk about specific methods that are supported. Should we talk about this or leave as-is?

@dsaxton dsaxton added Enhancement NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Oct 1, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
At some point, we should move the implementation (and tests) to a common "NumericArray", I suppose

@jreback
Copy link
Contributor

jreback commented Oct 2, 2020

actually if you rebase I think you can push these down to BaseMaskedArray entirely (or factor out to NumericMaskedArray if need to avoid the bool collision issues)

@jreback jreback added this to the 1.2 milestone Oct 2, 2020
@jreback
Copy link
Contributor

jreback commented Oct 2, 2020

great ping on green.

@jreback jreback merged commit 459aca9 into pandas-dev:master Oct 3, 2020
@jreback
Copy link
Contributor

jreback commented Oct 3, 2020

thanks

@dsaxton dsaxton deleted the floating-array-reductions branch October 3, 2020 05:18
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants