Skip to content

CLN: moments/test_moments_rolling.py for apply #36676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 26, 2020
Merged

CLN: moments/test_moments_rolling.py for apply #36676

merged 3 commits into from
Sep 26, 2020

Conversation

mroeschke
Copy link
Member

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Overall easier to grok these tests.

@mroeschke mroeschke added Clean Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding labels Sep 26, 2020
@mroeschke mroeschke added this to the 1.2 milestone Sep 26, 2020
@jreback jreback merged commit ec46f2e into pandas-dev:master Sep 26, 2020
@jreback
Copy link
Contributor

jreback commented Sep 26, 2020

great thanks

@mroeschke mroeschke deleted the cln/moments_rolling_apply branch September 26, 2020 23:39
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
@mroeschke
CLN: moments/test_moments_rolling.py for apply (pandas-dev#36676)
e430ffc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jreback