STY/WIP: check for private imports/lookups #36055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 4, 2020
|
looks good. |
jbrockmendel
force-pushed
the
sty-private
branch
from
ed18b43 to
b739aa0
Compare
|
We're down to 4 things that need to either be renamed or add to the ignore list: _GroupBy, _Rolling, _Rolling_and_Expanding, _IntegerDtype. @mroeschke any preferences for the Rolling names? |
|
No preference for those. |
|
green, booyah |
|
very nice! (hopefully recent merges don't break on this :->) |
|
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly this is an amalgam of #33479, #33394, and #33393.