Skip to content

(WIP) CI: Check private function not used across modules #33394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Apr 8, 2020


cc @jbrockmendel

@jbrockmendel
Copy link
Member

Nice. I'm not aware of any alternative to sys._getframe, but the others we should be able to either track down alternatives or de-privatize

@ShaharNaveh
Copy link
Member Author

Nice. I'm not aware of any alternative to sys._getframe, but the others we should be able to either track down alternatives or de-privatize

It will be very easy to white-list sys._getframe or for that matter, any other class/module/function...

@jbrockmendel
Copy link
Member

just pushed with rebase

@jbrockmendel
Copy link
Member

@MomIsBestFriend can we exclude the tests directory here

@jbrockmendel
Copy link
Member

@MomIsBestFriend you ok? havent heard from you in a while

@ShaharNaveh
Copy link
Member Author

@MomIsBestFriend you ok? havent heard from you in a while

Yes I am perfectly fine, due to COVID-19 I have much more work IRL, and I am not able to contribute to pandas ATM 😞

When I have the time I'll be back to contribute once again.

Thank you for thinking about me @jbrockmendel <3

@jreback
Copy link
Contributor

jreback commented Jun 14, 2020

nice idea, please comment if you can come back to this / open a new PR

@jreback jreback closed this Jun 14, 2020
@jreback jreback added the CI Continuous Integration label Jun 14, 2020
@ShaharNaveh ShaharNaveh deleted the CI-PrivateFunctionAcrossModules branch May 5, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants