-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
(WIP) CI: Check private function not used across modules #33394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) CI: Check private function not used across modules #33394
Conversation
Nice. I'm not aware of any alternative to sys._getframe, but the others we should be able to either track down alternatives or de-privatize |
It will be very easy to white-list |
…-PrivateFunctionAcrossModules
just pushed with rebase |
@MomIsBestFriend can we exclude the tests directory here |
…-PrivateFunctionAcrossModules
@MomIsBestFriend you ok? havent heard from you in a while |
…-PrivateFunctionAcrossModules
Yes I am perfectly fine, due to COVID-19 I have much more work IRL, and I am not able to contribute to pandas ATM 😞 When I have the time I'll be back to contribute once again. Thank you for thinking about me @jbrockmendel <3 |
nice idea, please comment if you can come back to this / open a new PR |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
cc @jbrockmendel