Added option to ignore file paths #33479
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you merge master test failures will be resolved |
| for file_name in files: | ||
| if not any( | ||
| file_name.endswith(extension) for extension in FILE_EXTENSIONS_TO_CHECK | ||
| ): | ||
| continue | ||
|
|
||
| file_path = os.path.join(subdir, file_name) | ||
| with open(file_path, "r") as file_obj: | ||
| with open(file_path, mode="r") as file_obj: |
There was a problem hiding this comment.
is making "mode" explicit necesary? its not a pattern we used elsewhere
| parser.add_argument( | ||
| "--excluded-file-paths", | ||
| default="asv_bench/env", | ||
| help="Coma seperated file extensions to check.", |
There was a problem hiding this comment.
Coma -> Comma (i hope)
seperated -> separated
looks like both of these need fixing on L395 too
jreback
added
CI
WillAyd
requested changes
Apr 22, 2020
|
Sorry, I got into other obligation in the past week and a half, I'll try to finish what I started as much as I can. |
|
can you merge master |
|
closing as stale, if you want to continue pls ping. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed both for #32942 and to #33394 to ignore the
pandas/testsdirectory