Skip to content

CLN: resolve isort mypy import confilict test_transform #35386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

CLN: resolve isort mypy import confilict test_transform #35386

merged 1 commit into from
Jul 29, 2020

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Jul 22, 2020 •
edited
Loading

Part of #35134

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@fangchenli fangchenli mentioned this pull request Jul 22, 2020
Closed
@simonjayhawkins simonjayhawkins added this to the 1.2 milestone Jul 24, 2020
@simonjayhawkins
Copy link
Member

@WillAyd I merged #35339 since you approved that. Are you OK with this and #35380

@WillAyd
Copy link
Member

WillAyd commented Jul 29, 2020 via email

@simonjayhawkins simonjayhawkins merged commit bb2ff33 into pandas-dev:master Jul 29, 2020
@simonjayhawkins
Copy link
Member

Thanks @VirosaLi

@fangchenli fangchenli deleted the isort-mypy-error-test_transform branch July 29, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@fangchenli @simonjayhawkins @WillAyd