Skip to content

CLN: resolve isort mypy import confilict test_algos #35339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

CLN: resolve isort mypy import confilict test_algos #35339

merged 1 commit into from
Jul 29, 2020

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Jul 18, 2020 •
edited
Loading

Part of #35134

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@fangchenli fangchenli mentioned this pull request Jul 18, 2020
Closed
@fangchenli fangchenli changed the title CI: resolve conflict mypy and isort CI: resolve conflict between mypy and isort Jul 19, 2020
@WillAyd WillAyd added the Clean label Jul 21, 2020
WillAyd
WillAyd approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added this to the 1.2 milestone Jul 21, 2020
@fangchenli fangchenli changed the title CI: resolve conflict between mypy and isort CLN: resolve conflict between mypy and isort Jul 22, 2020
@fangchenli fangchenli changed the title CLN: resolve conflict between mypy and isort CLN: resolve isort mypy import confilict test_algos Jul 22, 2020
@simonjayhawkins simonjayhawkins merged commit 55d2c65 into pandas-dev:master Jul 29, 2020
@simonjayhawkins
Copy link
Member

Thanks @VirosaLi

@simonjayhawkins simonjayhawkins mentioned this pull request Jul 29, 2020
Merged
2 tasks
@fangchenli fangchenli deleted the isort-mypy-error-test_algos branch July 29, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@fangchenli @simonjayhawkins @WillAyd