Skip to content

CI: Update to isort 5 #35134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AlexKirko opened this issue Jul 6, 2020 · 8 comments · Fixed by #35470
Closed

CI: Update to isort 5 #35134

AlexKirko opened this issue Jul 6, 2020 · 8 comments · Fixed by #35470
Labels
CI Continuous Integration Code Style Code style, linting, code_checks

Comments

@AlexKirko
Copy link
Member

AlexKirko commented Jul 6, 2020 •
edited by TomAugspurger
Loading

isort 5.x is out with some changes to how it sorts. We'll need to update the code and unpin in our environment file.
@AlexKirko AlexKirko added Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jul 6, 2020
@AlexKirko AlexKirko mentioned this issue Jul 6, 2020
Merged
5 tasks
@jreback jreback added CI Continuous Integration Code Style Code style, linting, code_checks and removed Bug Needs Triage Issue that has not been reviewed by a pandas team member labels Jul 6, 2020
@jreback jreback added this to the 1.1 milestone Jul 6, 2020
@jreback
Copy link
Contributor

jreback commented Jul 6, 2020

love a PR to fix (can likely just drop the recursive kw) or could pin isort- either way us ok

@AlexKirko
Copy link
Member Author

Should be fine if we drop the keyword. Let me give it a try.

@AlexKirko
Copy link
Member Author

take

@AlexKirko AlexKirko mentioned this issue Jul 6, 2020
Merged
5 tasks
@AlexKirko
Copy link
Member Author

Yeah, no. Version 5 has changed the way it sorts imports, so it now throws a couple hundred errors on our file base. I'll pin isort for now, and we can check later if this new version breaks anything.

@TomAugspurger TomAugspurger changed the title CI-COMPAT: isort 5.0 removed --recursive key, so now CI checks fail CI: Update to isort 5 Jul 6, 2020
@TomAugspurger TomAugspurger modified the milestones: 1.1, Contributions Welcome Jul 6, 2020
@AlexKirko AlexKirko removed their assignment Jul 7, 2020
@fangchenli fangchenli mentioned this issue Jul 7, 2020
Closed
5 tasks
@fangchenli

This comment has been minimized.

Sign in to view
@fangchenli

This comment has been minimized.

Sign in to view
This was referenced Jul 18, 2020
Merged
Merged
fangchenli added a commit to fangchenli/pandas that referenced this issue Jul 22, 2020
@fangchenli
CLN: resolve isort mypy import conflict (pandas-dev#35134)
fe7bebf
@fangchenli fangchenli mentioned this issue Jul 22, 2020
Merged
2 tasks
simonjayhawkins pushed a commit that referenced this issue Jul 29, 2020
@fangchenli
CLN: resolve isort mypy import conflict (#35134) (#35386)
bb2ff33
@fangchenli fangchenli mentioned this issue Jul 29, 2020
Merged
3 tasks
@nixphix
Copy link
Contributor

nixphix commented Jul 30, 2020

@VirosaLi can I pick some from the list?

@fangchenli
Copy link
Member

@VirosaLi can I pick some from the list?

The latest version of isort has changed its way of sorting. There is no conflict between MyPy and Isort anymore. So I guess those changes are not needed anymore.

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this issue Aug 1, 2020
@fangchenli @meeseeksmachine
Backport PR pandas-dev#35470: CI: unpin isort 5 (pandas-dev#35134)
d7dd50d
@meeseeksmachine meeseeksmachine mentioned this issue Aug 1, 2020
Merged
simonjayhawkins pushed a commit that referenced this issue Aug 1, 2020
@meeseeksmachine @fangchenli
Backport PR #35470: CI: unpin isort 5 (#35134) (#35501)
e29d9bb 
Co-authored-by: Fangchen Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Continuous Integration Code Style Code style, linting, code_checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: unpin isort 5 (#35134) fangchenli/pandas
CI: update to isort 5 (#35134) fangchenli/pandas
5 participants
@jreback @TomAugspurger @nixphix @fangchenli @AlexKirko