TST verify return none inplace in tests/indexing #35230
Conversation
|
build failed, it says ci/run_tests.sh ImportError while loading conftest '/home/travis/build/pandas-dev/pandas/pandas/conftest.py'. ImportError: C extension: 'dtypes' from partially initialized module 'pandas._libs.tslibs' (most likely due to a circular import) (/home/travis/build/pandas-dev/pandas/pandas/_libs/tslibs/init.py) not built. If you want to import pandas from the source directory, you may need to run 'python setup.py build_ext --inplace --force' to build the C extensions first. The command "ci/run_tests.sh" exited with 4. |
|
had a similar issue locally and had to recompile everything ... |
| @@ -25,7 +25,8 @@ def test_detect_chained_assignment(): | |||
|
|
|||
| msg = "A value is trying to be set on a copy of a slice from a DataFrame" | |||
| with pytest.raises(com.SettingWithCopyError, match=msg): | |||
| zed["eyes"]["right"].fillna(value=555, inplace=True) | |||
| return_value = zed["eyes"]["right"].fillna(value=555, inplace=True) | |||
| assert return_value is None | |||
|
|
|||
r-toroxel
changed the title
|
|
||
| result = DataFrame(data) | ||
| expected = DataFrame.from_dict(dict(zip([0], data)), orient="index") | ||
| tm.assert_frame_equal(result, expected.reindex(result.index)) |
There was a problem hiding this comment.
Nit: Could you put the reindex in the expected = ... statement
mroeschke
added
the
Testing
|
@r-toroxel Thanks for the PR. The branch has conflicts with master. can you merge upstream/master |
|
thanks @r-toroxel |
verify we return none for all inplace calls in tests/indexing
related: #35210