Tst return none inplace series #35210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Missing-data
jreback
requested changes
Jul 10, 2020
| tm.assert_series_equal(sc, tc[~expected]) | ||
| assert return_value is None |
| tm.assert_series_equal(sc, tc[~expected]) | ||
| assert return_value is None |
| tm.assert_series_equal(sc, tc1[~expected]) | ||
| assert return_value is None |
| tm.assert_series_equal(sc, tc2[~expected]) | ||
| assert return_value is None |
| tm.assert_series_equal(sc, tc2[~expected]) | ||
| assert return_value is None |
| tm.assert_series_equal(sc, tc[~expected]) | ||
| assert return_value is None |
| tm.assert_series_equal(sc, tc[~expected]) | ||
| assert return_value is None |
| @@ -81,7 +82,8 @@ def test_sort_values(self, datetime_series): | |||
| "you must create a copy" | |||
| ) | |||
| with pytest.raises(ValueError, match=msg): | |||
| s.sort_values(inplace=True) | |||
| return_value = s.sort_values(inplace=True) | |||
There was a problem hiding this comment.
this likely doesn't execute, can you revert (and if you are testing withing other raises tests)
|
Thx @jreback. Resolved. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jreback
approved these changes
Jul 10, 2020
|
thanks @r-toroxel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
verify we return None for all inplace calls in /series
related: #35181 (comment)