Skip to content

TST Verifiy that dropna returns none when called inplace (#35179) #35181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 9, 2020
Merged

TST Verifiy that dropna returns none when called inplace (#35179) #35181

merged 8 commits into from
Jul 9, 2020

Conversation

r-toroxel
Copy link
Contributor

@r-toroxel r-toroxel commented Jul 8, 2020 •
edited by gfyoung
Loading

Closes #35179

@gfyoung gfyoung added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite labels Jul 9, 2020
@gfyoung gfyoung linked an issue Jul 9, 2020 that may be closed by this pull request
TST verify inplace ops return None #35179
Closed
@jreback jreback added this to the 1.1 milestone Jul 9, 2020
@jreback jreback merged commit 8295dc4 into pandas-dev:master Jul 9, 2020
@jreback
Copy link
Contributor

jreback commented Jul 9, 2020

thanks @r-toroxel

mind checking both drop_duplicates and duplicated for series in a similar way?

@r-toroxel r-toroxel mentioned this pull request Jul 10, 2020
Merged
@r-toroxel
Copy link
Contributor Author

no. made a pr: #35210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

TST verify inplace ops return None
3 participants
@r-toroxel @jreback @gfyoung