Skip to content

TST verify inplace ops return None #35179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
r-toroxel opened this issue Jul 8, 2020 · 2 comments · Fixed by #35181 or #35121
Closed

TST verify inplace ops return None #35179

r-toroxel opened this issue Jul 8, 2020 · 2 comments · Fixed by #35181 or #35121
Assignees
@r-toroxel
Labels
Testing pandas testing functions or related to the test suite
Milestone
1.1

Comments

@r-toroxel
Copy link
Contributor

r-toroxel commented Jul 8, 2020 •
edited
Loading

test if pandas methods, when called inplace, return None

drop_duplicates #35121. merged
dropna #35180
@r-toroxel
Copy link
Contributor Author

take

r-toroxel added a commit to r-toroxel/pandas that referenced this issue Jul 8, 2020
@r-toroxel
TST verify dropna inplace (pandas-dev#35179)
1fc7243
This was referenced Jul 8, 2020
Merged
Merged
@r-toroxel
Copy link
Contributor Author

#16529
read in this issue that inplace will be removed from pandas 2.
so I guess going on here would be fruitless?

This was linked to pull requests Jul 9, 2020
TST Verifiy that dropna returns none when called inplace (#35179) #35181
Merged
TST add test case for drop_duplicates #35121
Merged
@jreback jreback added the Testing pandas testing functions or related to the test suite label Jul 9, 2020
@jreback jreback added this to the 1.1 milestone Jul 9, 2020
jreback pushed a commit that referenced this issue Jul 9, 2020
@r-toroxel
TST Verifiy that dropna returns none when called inplace (#35179) (#3…
8295dc4 
…5181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@r-toroxel r-toroxel

Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
2 participants
@jreback @r-toroxel