TST add test case for drop_duplicates #35121
Conversation
|
Hello @r-toroxel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-07-07 17:55:33 UTC |
|
No. |
| def test_drop_duplicates_inplace_result(): | ||
| df = DataFrame({"a": [1, 2, 3], "b": [1, 2, 4], "c": [1, 6, 5]}) | ||
| result = df.drop_duplicates(inplace=True) | ||
| assert result is None |
There was a problem hiding this comment.
can you use assert_frame_equal(df, expected) and construct the expected.
ideally this test goes with other basic drop_duplicates call and we parameterize on inplace
There was a problem hiding this comment.
yes. just checking the return value goes well with the existing
test_drop_duplicates_inplace
moved it there.
jreback
added
Missing-data
| expected = orig[:2] | ||
| result = df | ||
| tm.assert_frame_equal(result, expected) | ||
| assert(return_value is None) |
There was a problem hiding this comment.
Nit: You can remove the parenthesis from all of these asserts
|
thanks @r-toroxel happy to take PRs to verify other inplace ops return None |
|
thanks. yes. created an issue. #35179 |
Add a test case to drop_duplicates for inplace=True.