-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TST verify return none inplace in tests/indexing #35230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 16 commits into
pandas-dev:master
from
r-toroxel:TST-verify-return-none-inplace-indexing
Jul 13, 2020
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
5c0a095
TST add test case to drop_duplicates for inplace=True
r-toroxel b004e05
Merge remote-tracking branch 'upstream/master'
r-toroxel 6b940bb
CLN PEP-8
r-toroxel 4b8679c
TST move to existing test
r-toroxel cb2ab5e
CLN remove parenthesis
r-toroxel 8fee1b7
Merge remote-tracking branch 'upstream/master'
r-toroxel 8c68a0a
Merge remote-tracking branch 'upstream/master'
r-toroxel 2369141
TST test from_tuple corner cases
r-toroxel 824b5f4
Merge remote-tracking branch 'upstream/master' into TST-more=corner-c…
r-toroxel 04a86a7
add comment
r-toroxel c1cf452
CLN run black formatting
r-toroxel 40faa87
CLN refactor case as separate test
r-toroxel 97fb2c1
TST verify return none inplace for indexing/
r-toroxel 7446d9f
CLN fix
r-toroxel 9f6b75e
CLN expected assignment
r-toroxel 9e6fd6d
merge upstream/master
r-toroxel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,7 +25,8 @@ def test_detect_chained_assignment(): | |
|
||
msg = "A value is trying to be set on a copy of a slice from a DataFrame" | ||
with pytest.raises(com.SettingWithCopyError, match=msg): | ||
zed["eyes"]["right"].fillna(value=555, inplace=True) | ||
return_value = zed["eyes"]["right"].fillna(value=555, inplace=True) | ||
assert return_value is None | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed this one |
||
|
||
def test_cache_updating(): | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could you put the reindex in the
expected = ...
statement