CLN: Remove redundant tests for .duplicated and .drop_duplicates in tests/base #32487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaturnFromTitan
changed the title
SaturnFromTitan
changed the title
|
Same comment as #32484 are you sure this doesn't lose any coverage? |
SaturnFromTitan
changed the title
…on a Series without duplicated values
SaturnFromTitan
changed the title
SaturnFromTitan
commented
Mar 12, 2020
Comment on lines
-666
to
-697
| idx = original.index[list(range(len(original))) + [5, 3]] | ||
| values = original._values[list(range(len(original))) + [5, 3]] | ||
| s = Series(values, index=idx, name="a") | ||
|
|
||
| expected = Series( | ||
| [False] * len(original) + [True, True], index=idx, name="a" | ||
| ) | ||
| tm.assert_series_equal(s.duplicated(), expected) | ||
| tm.assert_series_equal(s.drop_duplicates(), original) | ||
|
|
||
| base = [False] * len(idx) | ||
| base[3] = True | ||
| base[5] = True | ||
| expected = Series(base, index=idx, name="a") | ||
|
|
||
| tm.assert_series_equal(s.duplicated(keep="last"), expected) | ||
| tm.assert_series_equal( | ||
| s.drop_duplicates(keep="last"), s[~np.array(base)] | ||
| ) | ||
|
|
||
| base = [False] * len(original) + [True, True] | ||
| base[3] = True | ||
| base[5] = True | ||
| expected = Series(base, index=idx, name="a") | ||
|
|
||
| tm.assert_series_equal(s.duplicated(keep=False), expected) | ||
| tm.assert_series_equal( | ||
| s.drop_duplicates(keep=False), s[~np.array(base)] | ||
| ) | ||
|
|
||
| s.drop_duplicates(inplace=True) | ||
| tm.assert_series_equal(s, original) |
There was a problem hiding this comment.
Comment on lines
-658
to
-664
| expected = Series( | ||
| [False] * len(original), index=original.index, name="a" | ||
| ) | ||
| tm.assert_series_equal(original.duplicated(), expected) | ||
| result = original.drop_duplicates() | ||
| tm.assert_series_equal(result, original) | ||
| assert result is not original |
There was a problem hiding this comment.
Now tested in test_drop_duplicates_no_duplicates in tests/series/methods/test_drop_duplicates.py, see below
Comment on lines
-651
to
-655
| with pytest.raises( | ||
| TypeError, | ||
| match=r"drop_duplicates\(\) got an unexpected keyword argument", | ||
| ): | ||
| idx.drop_duplicates(inplace=True) |
There was a problem hiding this comment.
Now tested in test_drop_duplicates_inplace in tests/indexes/test_common.py, see below
Comment on lines
-618
to
-649
| # has_duplicates | ||
| assert not original.has_duplicates | ||
|
|
||
| # create repeated values, 3rd and 5th values are duplicated | ||
| idx = original[list(range(len(original))) + [5, 3]] | ||
| expected = np.array([False] * len(original) + [True, True], dtype=bool) | ||
| duplicated = idx.duplicated() | ||
| tm.assert_numpy_array_equal(duplicated, expected) | ||
| assert duplicated.dtype == bool | ||
| tm.assert_index_equal(idx.drop_duplicates(), original) | ||
|
|
||
| base = [False] * len(idx) | ||
| base[3] = True | ||
| base[5] = True | ||
| expected = np.array(base) | ||
|
|
||
| duplicated = idx.duplicated(keep="last") | ||
| tm.assert_numpy_array_equal(duplicated, expected) | ||
| assert duplicated.dtype == bool | ||
| result = idx.drop_duplicates(keep="last") | ||
| tm.assert_index_equal(result, idx[~expected]) | ||
|
|
||
| base = [False] * len(original) + [True, True] | ||
| base[3] = True | ||
| base[5] = True | ||
| expected = np.array(base) | ||
|
|
||
| duplicated = idx.duplicated(keep=False) | ||
| tm.assert_numpy_array_equal(duplicated, expected) | ||
| assert duplicated.dtype == bool | ||
| result = idx.drop_duplicates(keep=False) | ||
| tm.assert_index_equal(result, idx[~expected]) |
There was a problem hiding this comment.
Tested in test_drop_duplicates in tests/indexes/test_common.py which was extended and refactored, see below
Comment on lines
-609
to
-616
| # original doesn't have duplicates | ||
| expected = np.array([False] * len(original), dtype=bool) | ||
| duplicated = original.duplicated() | ||
| tm.assert_numpy_array_equal(duplicated, expected) | ||
| assert duplicated.dtype == bool | ||
| result = original.drop_duplicates() | ||
| tm.assert_index_equal(result, original) | ||
| assert result is not original |
There was a problem hiding this comment.
Now tested in test_drop_duplicates_no_duplicates in tests/indexes/test_common.py, see below
|
@WillAyd I added comments highlighting and linking the redundant tests. Where needed I extended the existing tests in |
|
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@jreback CI is green |
|
thanks @SaturnFromTitan there might be other opportunities to use the |
3 tasks
SeeminSyed
pushed a commit
to CSCD01-team01/pandas
that referenced
this pull request
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #23877
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffduplicated and drop_duplicates are already thoroughly tested in
tests/indexesandtests/series. I added comments to highlight the redundancy and extended the existing test cases where needed.