Skip to content

CLN: fixturize & split test_base #23877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jreback opened this issue Nov 23, 2018 · 3 comments · Fixed by #32725
Closed

CLN: fixturize & split test_base #23877

jreback opened this issue Nov 23, 2018 · 3 comments · Fixed by #32725
Assignees
Labels
Clean Testing pandas testing functions or related to the test suite

Comments

@jreback
Copy link
Contributor

jreback commented Nov 23, 2018

it would be nice to use our indices fixture rather than the self.indices in pandas/tests/test_base.py as this is a bit cleaner and more flexible esp with subclasses. We also might consider splitting up test_base.py to some extent by function maybe splitting up to

test_construction
test_set_ops
test_reshaping
test_indexing

would accept multiple PR's to close this.

@jreback jreback added Testing pandas testing functions or related to the test suite Difficulty Intermediate Clean labels Nov 23, 2018
@jreback jreback added this to the Contributions Welcome milestone Nov 23, 2018
@charlesdong1991
Copy link
Member

I would like to give a try if it hasn't been picked.
And I will appreciate a lot if you could explain a bit clearer about the issue, i haven't found self.indices in pandas/tests/test_base.py.

@nixphix
Copy link
Contributor

nixphix commented Nov 27, 2018

@charlesdong1991 I figured that we need to add fixture for indexes. @jreback I made some changes to test_base could you pls let me know if thats what you wanted to do?

@SaturnFromTitan
Copy link
Contributor

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants