-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
CLN: fixturize & split test_base #23877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would like to give a try if it hasn't been picked. |
@charlesdong1991 I figured that we need to add fixture for indexes. @jreback I made some changes to test_base could you pls let me know if thats what you wanted to do? |
5 tasks
take |
This was referenced Dec 6, 2019
Merged
3 tasks
3 tasks
This was referenced Feb 27, 2020
SaturnFromTitan
added a commit
to SaturnFromTitan/pandas
that referenced
this issue
Mar 15, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
it would be nice to use our
indices
fixture rather than the self.indices inpandas/tests/test_base.py
as this is a bit cleaner and more flexible esp with subclasses. We also might consider splitting up test_base.py to some extent by function maybe splitting up totest_construction
test_set_ops
test_reshaping
test_indexing
would accept multiple PR's to close this.
The text was updated successfully, but these errors were encountered: