CLN: Remove redundant index test from tests/base/test_ops.py

[SaturnFromTitan]

part of #23877

• tests added / passed
• passes black pandas
• passes git diff upstream/master -u -- "*.py" | flake8 --diff

Boolean indexing is already thoroughly tested in test_series_mask_boolean in tests/indexes/test_na_indexing.py - see here

[WillAyd]

On board with cleaning up, but are we not losing any coverage here? Maybe overlooking, but one that sticks out is indexing with an Index object which appears here but I think not in the test you linked to replace this?

[SaturnFromTitan]

Good point @WillAyd, I'll check that later. I was assuming that if we lose coverage, then I'd get a codecov warning here in the PR. Isn't there a bot for these sort of things?

[WillAyd]

We do have codecov but it’s not generally very insightful (at least for us)

…

Sent from my iPhone

On Mar 7, 2020, at 1:24 AM, Martin Winkel ***@***.***> wrote:  Good point @WillAyd, I'll check that later. I was assuming that if we lose coverage, then I'd get a codecov warning here in the PR. Isn't there a bot for these sort of things? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[SaturnFromTitan]

inspired by pytest-dev/pytest#1830

[SaturnFromTitan]

@WillAyd I think this is ready for another review now. I added an indexer_class parametrization to test_series_mask_boolean and refactored the test a little bit (which I mostly had to do to get it passing)

[SaturnFromTitan]

The empty scenario was previously covered with some redundant code in the bottom of the test. I moved it to the parametrization instead and adjusted the generic test code to handle it properly

[jreback]

looks ok, will have to look again after @WillAyd comments are addressed.

[SaturnFromTitan]

@jreback I addressed all comments of @WillAyd (added the lost test cases to the parametrization of test_series_mask_boolean)

[jreback]

thanks @SaturnFromTitan