CLN: Split and fixturized test_fillna in tests/base/test_ops.py #32483
Conversation
|
|
||
| if needs_i8_conversion(o): | ||
| @pytest.mark.parametrize("null_obj", [np.nan, None]) |
There was a problem hiding this comment.
Using nulls_fixture should be taken care of in #32437
|
@MomIsBestFriend Seems like that didn't work for the I'll revert it to a simple |
| if len(obj) == 0: | ||
| pytest.skip("Test doesn't make sense on empty data") | ||
| elif isinstance(obj, ABCMultiIndex): | ||
| pytest.skip("MultiIndex doesn't support isna") |
There was a problem hiding this comment.
See my comment below, this is related to MultiIndex not being able to hold "pure" NA values
| elif len(obj) < 1: | ||
| pytest.skip("Test doesn't make sense on empty data") | ||
| elif isinstance(obj, ABCMultiIndex): | ||
| pytest.skip(f"MultiIndex can't hold '{null_obj}'") |
There was a problem hiding this comment.
Isn't this by design? A MultiIndex must hold values on multiple levels, so its elements are tuples. Therefore a MultiIndex can't just hold a raw np.nan or None as a value. Maybe a tuple of nans might make sense, but I don't think that would be recognised as "na" by fillna.
|
thanks @SaturnFromTitan ideally if you can add the nulls fixture would be great :-> |
part of #23877
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff