Skip to content

Include tests for pd.NA and pd.NaT in tests/base/test_ops.py #32437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SaturnFromTitan opened this issue Mar 4, 2020 · 1 comment
Closed

Include tests for pd.NA and pd.NaT in tests/base/test_ops.py #32437

SaturnFromTitan opened this issue Mar 4, 2020 · 1 comment
Labels
Enhancement Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite

Comments

@SaturnFromTitan
Copy link
Contributor

This is a follow-up from #32281, specifically on this comment from jreback.

test_unique_null, test_nunique_null and test_value_counts_null should be tested for pd.NA and pd.NaT as well, ideally using the nulls_fixture from pandas/conftest.py.

As discovered/discussed in the mentioned PR, they would xfail for now. It's something that should be tested and ideally fixed though.
This was referenced Mar 4, 2020
Merged
Merged
@jbrockmendel jbrockmendel added the Testing pandas testing functions or related to the test suite label Mar 17, 2020
@mroeschke mroeschke added Enhancement Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels May 22, 2020
@mroeschke
Copy link
Member

I think we have coverage of this on other tests now so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jbrockmendel @mroeschke @SaturnFromTitan