TST: Split and simplify test_value_counts_unique_nunique #32281
Conversation
SaturnFromTitan
changed the title
SaturnFromTitan
changed the title
SaturnFromTitan
force-pushed
the
32205-simplify-test_value_counts_unique_nunique_null-in-pandas-tests-base-test_ops-py
branch
2 times, most recently
from
5a39679 to
b3f6091
Compare
|
The failing CI is unrelated to these changes |
SaturnFromTitan
force-pushed
the
32205-simplify-test_value_counts_unique_nunique_null-in-pandas-tests-base-test_ops-py
branch
from
b3f6091 to
e9e4489
Compare
…nique_null-in-pandas-tests-base-test_ops-py
|
@jreback merged master to resolve conflicts |
| result = obj.value_counts() | ||
| tm.assert_series_equal(result, expected_s) | ||
| assert result.index.name is None | ||
| @pytest.mark.parametrize("null_obj", [np.nan, None]) |
There was a problem hiding this comment.
I tried using nulls_fixture and unique_nulls_fixture. Nearly all configurations break for pd.NaT and pd.NA though...
There was a problem hiding this comment.
ok, yeah we need to test these, can you create an issue. we will want to add these even if they need xfailing for now as there is no testing on them.
There was a problem hiding this comment.
xref: #32437
| klass = type(obj) | ||
| values = obj._ndarray_values | ||
| num_values = len(orig) | ||
| def test_nunique_null(self, null_obj, index_or_series_obj): |
…nique_null-in-pandas-tests-base-test_ops-py
| result = obj.value_counts() | ||
| tm.assert_series_equal(result, expected_s) | ||
| assert result.index.name is None | ||
| @pytest.mark.parametrize("null_obj", [np.nan, None]) |
There was a problem hiding this comment.
ok, yeah we need to test these, can you create an issue. we will want to add these even if they need xfailing for now as there is no testing on them.
|
thanks @SaturnFromTitan one other followup on this. I think we should split out the tests you just changed (e.g. unique, value_counts) into a test_unique.py module; happy to do this generally as well (though should be separate from a refactorting PR). |
|
Will do. I'll wait until #32311 is merged though as I think it should go into the test_uniques.py as well |
closes #32205, closes #32220
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff