Skip to content

CI: mypy fixup for #32261 #32438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2020
Merged

CI: mypy fixup for #32261 #32438

merged 2 commits into from
Mar 4, 2020

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins added CI Continuous Integration Typing type annotations, mypy/pyright type checking labels Mar 4, 2020
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Mar 4, 2020
@simonjayhawkins simonjayhawkins mentioned this pull request Mar 4, 2020
Merged
5 tasks
@WillAyd
Copy link
Member

WillAyd commented Mar 4, 2020

Thanks for looking at the CI failures. Looks like you have a few PRs - can you advise on the priority of the,?

@simonjayhawkins
Copy link
Member Author

Thanks for looking at the CI failures. Looks like you have a few PRs - can you advise on the priority of the,?

hold on this for a minute.

@simonjayhawkins
Copy link
Member Author

need to check Windows py36_np15

@simonjayhawkins
Copy link
Member Author

need to check Windows py36_np15

looks like test_value_counts_null is still flakey, xref #32281 cc @SaturnFromTitan

@SaturnFromTitan
Copy link
Contributor

darn.. I'll have a look

@SaturnFromTitan
Copy link
Contributor

Can you point me to a stacktrace for further investigation @simonjayhawkins?

@simonjayhawkins
Copy link
Member Author

@SaturnFromTitan https://dev.azure.com/pandas-dev/pandas/_build/results?buildId=29965&view=logs&j=077026cf-93c0-54aa-45e0-9996ba75f6f7&t=e95cf409-86ae-5b4d-6c5f-79395ef75e8f

@SaturnFromTitan SaturnFromTitan mentioned this pull request Mar 4, 2020
Merged
@simonjayhawkins
Copy link
Member Author

@WillAyd I think this is ok to merge now.

@WillAyd WillAyd merged commit c5f11ab into pandas-dev:master Mar 4, 2020
@WillAyd
Copy link
Member

WillAyd commented Mar 4, 2020

Thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins deleted the mypy-fixup branch March 5, 2020 10:13
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@WillAyd @SeeminSyed
CI: mypy fixup for pandas-dev#32261 (pandas-dev#32438)
c517b60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@simonjayhawkins @WillAyd @SaturnFromTitan