-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: lazify blknos and blklocs #32261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Some asv results
|
Near-identical asv results from a second run |
""" | ||
if self._blknos is None: | ||
# Note: these can be altered by other BlockManager methods. | ||
self._rebuild_blknos_and_blklocs() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to make this more transparent, I would change the return signature of _rebuild_blknos_and_blklocs to return a tuple of (blknos, blklocs) and set them here. It is much more transparent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that turns out to get messy because of the way we update these in-place in some other methods. so id like to skip this for now, and revisit it in the upcoming even-lazier pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.
The benchmark I'm using for this is the same as for #32224, based on the asv that is most affected by removing
fast_apply
(see #32086)If we disable
fast_apply
on master, this gives:If we disable
fast_apply
on this PR: