REF: PeriodIndex.get_loc #31021
Merged
REF: PeriodIndex.get_loc #31021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Jan 14, 2020
pandas/core/indexes/period.py
Outdated
| ordinal = key.ordinal if key is not NaT else NaT.value | ||
| loc = self._engine.get_loc(ordinal) | ||
| return series[loc] | ||
| value = Index.get_value(self, series, key) |
There was a problem hiding this comment.
this slipped in, will trim
jreback
added
Indexing
|
thanks @jbrockmendel |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #30874 which does similar cleanup for TimedeltaIndex.
Do all parsing/casting/conversion before call to self._engine or super() methods (xref #30948)
Fix+test integers incorrectly getting through.