Skip to content

CLN: fix wrong types getting passed to TDI._get_string_slice #30874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 20, 2020
Merged

CLN: fix wrong types getting passed to TDI._get_string_slice #30874

merged 4 commits into from
Jan 20, 2020

Conversation

jbrockmendel
Copy link
Member

Removes unreachable code paths.

@jbrockmendel jbrockmendel added the Indexing Related to indexing on series/frames, not to indexes themselves label Jan 11, 2020
@jbrockmendel
Copy link
Member Author

@jreback gentle ping; lots of indexing cleanups afoot a

This was referenced Jan 14, 2020
Merged
Merged
@jreback jreback added the Timedelta Timedelta data type label Jan 18, 2020
@jreback jreback added this to the 1.1 milestone Jan 18, 2020
@jreback jreback merged commit cd7c784 into pandas-dev:master Jan 20, 2020
@jreback
Copy link
Contributor

jreback commented Jan 20, 2020

thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the cln-tdi-unreachable branch January 20, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Indexing Related to indexing on series/frames, not to indexes themselves Timedelta Timedelta data type
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback