Skip to content

DOC: add 1.0.1 whatsnew file #30907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 30, 2020
Merged

DOC: add 1.0.1 whatsnew file #30907

merged 6 commits into from
Jan 30, 2020

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Jan 11, 2020

No description provided.

@WillAyd WillAyd added the Docs label Jan 11, 2020
@jbrockmendel
Copy link
Member

lgtm

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Jan 11, 2020
simonjayhawkins
simonjayhawkins reviewed Jan 11, 2020
View reviewed changes
doc/source/whatsnew/v1.0.1.rst
@@ -0,0 +1,134 @@
.. _whatsnew_101:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't yet have a milestone or branch for this (will be 1.0.x after 1.0 release?), how do you get just this file to backport to a 1.0.1. I don't think this should be added yet

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea good point. Can do as separate PRs and only backport the one

@simonjayhawkins simonjayhawkins mentioned this pull request Jan 11, 2020
Merged
5 tasks
@EmilianoJordan EmilianoJordan mentioned this pull request Jan 12, 2020
Merged
5 tasks
@WillAyd WillAyd modified the milestones: 1.1, 1.0.0 Jan 13, 2020
@WillAyd WillAyd changed the title New Whatsnews files 1.0.1 Whatsnew Jan 13, 2020
simonjayhawkins
simonjayhawkins reviewed Jan 13, 2020
View reviewed changes
doc/source/whatsnew/index.rst
Version 1.0
-----------

.. toctree::
:maxdepth: 2

v1.0.0
v1.0.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also be removed or not critical?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since I linked to this PR for the 1.1 whatsnew, This PR should retain the 1.1 setup and open another PR for 1.0.1 (but only after 1.0 is released)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is for 1.0.1

@TomAugspurger
Copy link
Contributor

I don't think this should be on the 1.0.0 milestone, right?

@WillAyd
Copy link
Member Author

WillAyd commented Jan 13, 2020

What milestone are we using for things needing back ports?

jreback
jreback requested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What milestone are we using for things needing back ports?

agreed with @TomAugspurger this needs to wait until after we release 1.0.0

@jreback jreback modified the milestones: 1.0.0, 1.0.1 Jan 14, 2020
jorisvandenbossche
jorisvandenbossche approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be merged now 1.0.0 is released

@jorisvandenbossche jorisvandenbossche changed the title 1.0.1 Whatsnew DOC: add 1.0.1 whatsnew file Jan 30, 2020
@jorisvandenbossche jorisvandenbossche merged commit 761bceb into pandas-dev:master Jan 30, 2020
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 30, 2020
@WillAyd @meeseeksmachine
Backport PR pandas-dev#30907: DOC: add 1.0.1 whatsnew file
cbbcb23
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 30, 2020
Merged
jorisvandenbossche pushed a commit that referenced this pull request Jan 30, 2020
@meeseeksmachine @WillAyd
Backport PR #30907: DOC: add 1.0.1 whatsnew file (#31443)
3c25fd6 
Co-authored-by: William Ayd <[email protected]>
@WillAyd WillAyd deleted the new-whatsnews branch January 30, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins left review comments

@jreback jreback jreback requested changes

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.0.1
Development

Successfully merging this pull request may close these issues.
6 participants
@WillAyd @jbrockmendel @TomAugspurger @jreback @jorisvandenbossche @simonjayhawkins