BUG: Use self._constructor_sliced in df._reduce to respect subclassed… #30945
Conversation
There was a problem hiding this comment.
Thanks @EmilianoJordan for the PR. will need whatsnew once #30907 is merged.
simonjayhawkins
added
Bug
Numeric Operations
Subscribed to #30907 to know when I can do this. Also, updated the initial pull request comment to reflect that this has not been completed. |
Add whatsnew/v1.1.0rst
doc/source/whatsnew/v1.1.0.rst
Outdated
| @@ -140,7 +140,7 @@ Groupby/resample/rolling | |||
| Reshaping | |||
| ^^^^^^^^^ | |||
|
|
|||
| - | |||
| - Bug in :meth:`DataFrame._reduce` not returning subclassed data type effecting all numeric and boolean reduction methods. (:issue:`25596`) | |||
There was a problem hiding this comment.
this is not a public method, can you update with something a user would want to know, e.g. DataFrame.sum() etc.
There was a problem hiding this comment.
List all 12 methods then?
There was a problem hiding this comment.
I'm working on a more comprehensive review of subclassing. How about I just add that to this PR and list all the methods? It'll be ~20 methods, but it'll get it all out of the way in one go.
There was a problem hiding this comment.
u can list if u want or just sat reduction methods
|
thanks @EmilianoJordan |
… types. (GH25596)
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff