raise more specific error if dict is appended to frame wit… #30882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
simonjayhawkins
added
the
Error Reporting
simonjayhawkins
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
Thanks @MarcoGorelli for the PR. lgtm. although I think that a note in the other section of the whatsnew to say the message has been changed might be warranted. see what others think.
MarcoGorelli
force-pushed
the
append-dict
branch
from
c82b88d to
2dc4b3e
Compare
simonjayhawkins
requested changes
Jan 11, 2020
doc/source/whatsnew/v1.0.0.rst
Outdated
| @@ -1170,6 +1170,8 @@ Other | |||
| - Bug where :meth:`DataFrame.itertuples` would incorrectly determine whether or not namedtuples could be used for dataframes of 255 columns (:issue:`28282`) | |||
| - Handle nested NumPy ``object`` arrays in :func:`testing.assert_series_equal` for ExtensionArray implementations (:issue:`30841`) | |||
| - Bug in :class:`Index` constructor incorrectly allowing 2-dimensional input arrays (:issue:`13601`, :issue:`27125`) | |||
| - Appending a dictionary to a :class:`DataFrame` without passing ``ignore_index=True`` will raise ``TypeError: Can only append a dict if ignore_index=True`` | |||
| instead of ``TypeError: Can only append a Series if ignore_index=True or if the Series has a name`` (:issue`30871`) | |||
There was a problem hiding this comment.
This will need to go in doc/source/whatsnew/v1.1.0.rst once #30907 is merged
WillAyd
requested changes
Jan 16, 2020
| @@ -7023,6 +7023,8 @@ def append( | |||
| """ | |||
| if isinstance(other, (Series, dict)): | |||
| if isinstance(other, dict): | |||
| if not ignore_index: | |||
There was a problem hiding this comment.
Rather than adding another branch here can you just use an f-string and do f"Can only append a {type(other)}...
There was a problem hiding this comment.
Could do, but then I'll need to add another branch later as the message for Series has an extra part compared to that for dict: "or if the Series has a name"
MarcoGorelli
force-pushed
the
append-dict
branch
from
2dc4b3e to
3dac8b8
Compare
simonjayhawkins
approved these changes
Jan 17, 2020
MarcoGorelli
force-pushed
the
append-dict
branch
from
00852df to
891bfe5
Compare
WillAyd
approved these changes
Jan 20, 2020
|
Thanks @MarcoGorelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hout ignore_index
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff