CI: 3.8 build #28730
CI: 3.8 build #28730
Conversation
There was a problem hiding this comment.
I think the failure is a result of changing the dist. This link might have the answer:
https://docs.travis-ci.com/user/trusty-to-xenial-migration-guide#1-services-support
I think would need to add that key for both mysql and psql
|
see #27266 as well here |
|
For a moment I was amazed that the last "restore everything disabled during debugging" commit came back green. Then I saw that I had mangled the Travis config so badly that Travis didn't run at all. |
|
FYI, on the NumPy mailing list they announced that they built 3.8 wheels. Looks like https://github.com/MacPython/numpy-wheels/blob/master/.travis.yml Maybe MacPython/numpy-wheels@9d8a0ad + an update of multibuild in the pandas-wheels repo would do the trick. |
Does this replace the approach being taken in this PR? Or supplement? |
|
Reverted to use git clone, with comment about possible pip alternative |
| - sleep 3 | ||
|
|
||
| script: | ||
| - echo "script start" | ||
| - source activate pandas-dev | ||
| - echo "$JOB" | ||
| - if [ "$JOB" != "3.8-dev" ]; then source activate pandas-dev; fi |
There was a problem hiding this comment.
why is this not also called pandas-dev (the env name)?
There was a problem hiding this comment.
You mean $JOB? none of the other $JOB values have pandas-dev in the name
| @@ -0,0 +1,25 @@ | |||
| #!/bin/bash -e | |||
| # Special build for python3.8 until numpy puts its own wheels up | |||
|
|
|||
There was a problem hiding this comment.
you should create a bare conda env here
There was a problem hiding this comment.
3.8 should not be very different than a regular setup
There was a problem hiding this comment.
It has to be different until there are 3.8 packages (python especially, but also our dependencies).
I think Brock has about the minimal difference we can get right now.
|
@jreback thoughts on #28730 (comment)? 3.8 is out now, so I'd like to get this in and 0.25.2 released as soon as possible (ideally by sometime tomorrow). |
|
#29001 for followup. Thanks @jbrockmendel. |
Travis config is a mystery to me, so this is trial-and-error until I get the hang of it.
Closes #26626